Hi Keith,

On Fri, 2006-02-17 at 06:53 -0800, Keith Seitz wrote:
> >> +    os.writeInt(VMFrame.size ()); // frameId
> >> [...]
> >> +  public static int size ()
> > 
> > Both method invocation and method declaration don't have a space between
> > the method name and the opening bracket. This is different from the C
> > coding style guide (and not always followed in all our code...)
> 
> Ah, so no spaces at all between method names and parentheses in 
> Classpath? Is there a standard list of options to GNU indent through 
> which I can run the code to get an acceptable output which I can commit 
> en masse?

If you want to use GNU indent you need some patches from Bryce:
http://lists.gnu.org/archive/html/classpath/2000-10/msg00019.html
And then run it as indent -nfc1 -npcs
(This is old though, and I don't know if anybody actually uses this
method anymore.)

There is also the standalone packaged Eclipse Formatter for Java by Ben:
http://www.bagu.org/eclipse/efj/
Which might already be packaged for your favorite distro (Debian has the
eclipse-efj package). In classpath CVS you will find
scripts/eclipse-gnu.xml which can be used with this formatter.

In both cases please do review the output carefully. Neither method is
foolproof and does require some human judgment on corner cases.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to