On Mon, 2006-02-20 at 17:33 -0500, Anthony Balkissoon wrote: > On Mon, 2006-02-20 at 15:09 -0500, Anthony Balkissoon wrote: > > This is RFC because it's my first commit to the generics branch and I > > just want to make sure there aren't any special procedures I forgot. > > > > 2006-02-20 Anthony Balkissoon <[EMAIL PROTECTED]> > > > > * java/math/RoundingMode: New Enum. > > > > --Tony > > > This is replaced by: > 2006-02-20 Anthony Balkissoon <[EMAIL PROTECTED]> > > * java/math/MathContext.java: New class. > * java/math/RoundingMode: New Enum. > > Also, I forgot to put the GNU Classpath header in RoundingMode, but this > patch includes it. Comments are still appreciated. I'll commit this > tomorrow if no one objects. > > --Tony
Looks fine to me -- the header would have been my only comment. Of course, I'm assuming it applies cleanly and compiles... ;) It's a pity this new math stuff uses an enum for RoundingMode, because AFAICS that's the only thing that restricts this to the generics branch. -- Andrew :-) Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments. See http://www.fsf.org/philosophy/no-word-attachments.html If you use Microsoft Office, support movement towards the end of vendor lock-in: http://opendocumentfellowship.org/petition/ "Value your freedom, or you will lose it, teaches history. `Don't bother us with politics' respond those who don't want to learn." -- Richard Stallman Escape the Java Trap with GNU Classpath! http://www.gnu.org/philosophy/java-trap.html public class gcj extends Freedom implements Java { ... }
