Hi,
looking at the reverse japi results there are several classes pointed
out which are final or abstract in the JDK and non-final / concrete
in classpath. The patch fixes some of them.
2006-03-14 Wolfgang Baer <[EMAIL PROTECTED]>
* org/omg/PortableInterceptor/ORBInitInfoPackage/ObjectIdHelper.java,
* org/omg/PortableServer/ServantActivatorPOA.java,
* org/omg/PortableServer/ServantLocatorPOA.java:
Make class abstract and minor api docs fixlets.
* org/omg/PortableServer/ForwardRequest.java,
* org/omg/PortableServer/ServantLocatorPackage/CookieHolder.java,
* org/omg/PortableServer/POAPackage/AdapterAlreadyExists.java,
* org/omg/PortableServer/POAPackage/AdapterNonExistent.java,
* org/omg/PortableServer/POAPackage/InvalidPolicy.java,
* org/omg/PortableServer/POAPackage/NoServant.java,
* org/omg/PortableServer/POAPackage/ObjectAlreadyActive.java,
* org/omg/PortableServer/POAPackage/ObjectNotActive.java,
* org/omg/PortableServer/POAPackage/ServantAlreadyActive.java,
* org/omg/PortableServer/POAPackage/ServantNotActive.java,
* org/omg/PortableServer/POAPackage/WrongAdapter.java,
* org/omg/PortableServer/POAPackage/WrongPolicy.java,
* org/omg/PortableServer/POAManagerPackage/AdapterInactive.java,
* org/omg/PortableInterceptor/ORBInitInfoPackage/InvalidName.java,
* org/omg/PortableInterceptor/ORBInitInfoPackage/DuplicateName.java,
* org/omg/PortableServer/CurrentPackage/NoContext.java:
Make class final.
Wolfgang
Index: org/omg/PortableInterceptor/ORBInitInfoPackage/ObjectIdHelper.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableInterceptor/ORBInitInfoPackage/ObjectIdHelper.java,v
retrieving revision 1.4
diff -u -r1.4 ObjectIdHelper.java
--- org/omg/PortableInterceptor/ORBInitInfoPackage/ObjectIdHelper.java 28 Oct 2005 12:04:47 -0000 1.4
+++ org/omg/PortableInterceptor/ORBInitInfoPackage/ObjectIdHelper.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ObjectIdHelper.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -53,10 +53,10 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ObjectIdHelper
+public abstract class ObjectIdHelper
{
/**
- * Insert the Object Id into Any (uses [EMAIL PROTECTED] Any.insert_string}).
+ * Insert the Object Id into Any (uses [EMAIL PROTECTED] Any#insert_string(String)}).
*
* @param a the Any to insert into.
* @param that the string to insert.
@@ -67,7 +67,7 @@
}
/**
- * Extract the Object Id from Any ((uses [EMAIL PROTECTED] Any.extract_string}).
+ * Extract the Object Id from Any (uses [EMAIL PROTECTED] Any#extract_string()}).
*
* @param a the Any to extract from.
*/
@@ -105,7 +105,7 @@
}
/**
- * Calls [EMAIL PROTECTED] OutputStream#write_string()}.
+ * Calls [EMAIL PROTECTED] OutputStream#write_string(String)}.
*
* @param output the stream to write into.
* @param value the string (Object Id) value to write.
Index: org/omg/PortableInterceptor/ORBInitInfoPackage/InvalidName.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableInterceptor/ORBInitInfoPackage/InvalidName.java,v
retrieving revision 1.3
diff -u -r1.3 InvalidName.java
--- org/omg/PortableInterceptor/ORBInitInfoPackage/InvalidName.java 28 Aug 2005 11:23:37 -0000 1.3
+++ org/omg/PortableInterceptor/ORBInitInfoPackage/InvalidName.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* InvalidName.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -52,7 +52,7 @@
*
* @author Audrius Meskauskas, Lithiania ([EMAIL PROTECTED])
*/
-public class InvalidName extends UserException implements IDLEntity,
+public final class InvalidName extends UserException implements IDLEntity,
Serializable
{
/**
Index: org/omg/PortableInterceptor/ORBInitInfoPackage/DuplicateName.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableInterceptor/ORBInitInfoPackage/DuplicateName.java,v
retrieving revision 1.3
diff -u -r1.3 DuplicateName.java
--- org/omg/PortableInterceptor/ORBInitInfoPackage/DuplicateName.java 28 Aug 2005 11:23:37 -0000 1.3
+++ org/omg/PortableInterceptor/ORBInitInfoPackage/DuplicateName.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* DuplicateName.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -54,7 +54,7 @@
*
* @author Audrius Meskauskas, Lithiania ([EMAIL PROTECTED])
*/
-public class DuplicateName extends UserException implements IDLEntity,
+public final class DuplicateName extends UserException implements IDLEntity,
Serializable
{
/**
Index: org/omg/PortableServer/ServantActivatorPOA.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/ServantActivatorPOA.java,v
retrieving revision 1.1
diff -u -r1.1 ServantActivatorPOA.java
--- org/omg/PortableServer/ServantActivatorPOA.java 22 Jul 2005 16:57:47 -0000 1.1
+++ org/omg/PortableServer/ServantActivatorPOA.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ServantActivatorPOA.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -58,11 +58,11 @@
* You do not need to derive your servant activator from this stub,
* it is enough to implement the [EMAIL PROTECTED] ServantActivator} interface.
* But you may choose to do this if you need the functional
- * [EMAIL PROTECTED] #_all_interfaces()} method or want to keep default behavior during
- * the incarnation or etherialization.
+ * [EMAIL PROTECTED] #_all_interfaces(POA, byte[])} method or want to keep default
+ * behavior during the incarnation or etherialization.
* </p>
*/
-public class ServantActivatorPOA
+public abstract class ServantActivatorPOA
extends Servant
implements InvokeHandler, ServantActivatorOperations
{
Index: org/omg/PortableServer/ServantLocatorPOA.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/ServantLocatorPOA.java,v
retrieving revision 1.1
diff -u -r1.1 ServantLocatorPOA.java
--- org/omg/PortableServer/ServantLocatorPOA.java 22 Jul 2005 16:57:47 -0000 1.1
+++ org/omg/PortableServer/ServantLocatorPOA.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ServantLocatorPOA.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -59,12 +59,12 @@
* You do not need to derive your servant locator from this stub,
* it is enough to implement the [EMAIL PROTECTED] ServantLocator} interface.
* But you may choose to do this if you need its functional
- * [EMAIL PROTECTED] #_ids()} method or want to keep default behavior during per-
- * or post- invokcations.
+ * [EMAIL PROTECTED] org.omg.PortableServer.ServantActivatorPOA.delegator#_ids()}
+ * method or want to keep default behaviour during pre- or post- invokcations.
* </p>
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ServantLocatorPOA
+public abstract class ServantLocatorPOA
extends Servant
implements ServantLocatorOperations, InvokeHandler
{
Index: org/omg/PortableServer/ForwardRequest.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/ForwardRequest.java,v
retrieving revision 1.2
diff -u -r1.2 ForwardRequest.java
--- org/omg/PortableServer/ForwardRequest.java 24 Aug 2005 22:57:08 -0000 1.2
+++ org/omg/PortableServer/ForwardRequest.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ForwardRequest.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -60,7 +60,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ForwardRequest
+public final class ForwardRequest
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/ServantLocatorPackage/CookieHolder.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/ServantLocatorPackage/CookieHolder.java,v
retrieving revision 1.1
diff -u -r1.1 CookieHolder.java
--- org/omg/PortableServer/ServantLocatorPackage/CookieHolder.java 2 Jul 2005 23:25:45 -0000 1.1
+++ org/omg/PortableServer/ServantLocatorPackage/CookieHolder.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* CookieHolder.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -56,7 +56,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class CookieHolder
+public final class CookieHolder
implements Streamable
{
/**
Index: org/omg/PortableServer/POAPackage/AdapterAlreadyExists.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/AdapterAlreadyExists.java,v
retrieving revision 1.2
diff -u -r1.2 AdapterAlreadyExists.java
--- org/omg/PortableServer/POAPackage/AdapterAlreadyExists.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/AdapterAlreadyExists.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* AdapterAlreadyExists.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class AdapterAlreadyExists
+public final class AdapterAlreadyExists
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/AdapterNonExistent.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/AdapterNonExistent.java,v
retrieving revision 1.2
diff -u -r1.2 AdapterNonExistent.java
--- org/omg/PortableServer/POAPackage/AdapterNonExistent.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/AdapterNonExistent.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* AdapterNonExistent.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class AdapterNonExistent
+public final class AdapterNonExistent
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/InvalidPolicy.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/InvalidPolicy.java,v
retrieving revision 1.2
diff -u -r1.2 InvalidPolicy.java
--- org/omg/PortableServer/POAPackage/InvalidPolicy.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/InvalidPolicy.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* InvalidPolicy.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -52,7 +52,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class InvalidPolicy
+public final class InvalidPolicy
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/NoServant.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/NoServant.java,v
retrieving revision 1.2
diff -u -r1.2 NoServant.java
--- org/omg/PortableServer/POAPackage/NoServant.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/NoServant.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* NoServant.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class NoServant
+public final class NoServant
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/ObjectAlreadyActive.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/ObjectAlreadyActive.java,v
retrieving revision 1.2
diff -u -r1.2 ObjectAlreadyActive.java
--- org/omg/PortableServer/POAPackage/ObjectAlreadyActive.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/ObjectAlreadyActive.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ObjectAlreadyActive.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -48,7 +48,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ObjectAlreadyActive
+public final class ObjectAlreadyActive
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/ObjectNotActive.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/ObjectNotActive.java,v
retrieving revision 1.2
diff -u -r1.2 ObjectNotActive.java
--- org/omg/PortableServer/POAPackage/ObjectNotActive.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/ObjectNotActive.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ObjectNotActive.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ObjectNotActive
+public final class ObjectNotActive
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/ServantAlreadyActive.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/ServantAlreadyActive.java,v
retrieving revision 1.2
diff -u -r1.2 ServantAlreadyActive.java
--- org/omg/PortableServer/POAPackage/ServantAlreadyActive.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/ServantAlreadyActive.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ServantAlreadyActive.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -53,7 +53,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ServantAlreadyActive
+public final class ServantAlreadyActive
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/ServantNotActive.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/ServantNotActive.java,v
retrieving revision 1.2
diff -u -r1.2 ServantNotActive.java
--- org/omg/PortableServer/POAPackage/ServantNotActive.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/ServantNotActive.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* ServantNotActive.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class ServantNotActive
+public final class ServantNotActive
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/WrongAdapter.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/WrongAdapter.java,v
retrieving revision 1.2
diff -u -r1.2 WrongAdapter.java
--- org/omg/PortableServer/POAPackage/WrongAdapter.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/WrongAdapter.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* WrongAdapter.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -50,7 +50,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class WrongAdapter
+public final class WrongAdapter
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAPackage/WrongPolicy.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAPackage/WrongPolicy.java,v
retrieving revision 1.2
diff -u -r1.2 WrongPolicy.java
--- org/omg/PortableServer/POAPackage/WrongPolicy.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAPackage/WrongPolicy.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* WrongPolicy.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class WrongPolicy
+public final class WrongPolicy
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/POAManagerPackage/AdapterInactive.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/POAManagerPackage/AdapterInactive.java,v
retrieving revision 1.2
diff -u -r1.2 AdapterInactive.java
--- org/omg/PortableServer/POAManagerPackage/AdapterInactive.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/POAManagerPackage/AdapterInactive.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* AdapterInactive.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -49,7 +49,7 @@
*
* @author Audrius Meskauskas, Lithuania ([EMAIL PROTECTED])
*/
-public class AdapterInactive
+public final class AdapterInactive
extends UserException
implements IDLEntity, Serializable
{
Index: org/omg/PortableServer/CurrentPackage/NoContext.java
===================================================================
RCS file: /cvsroot/classpath/classpath/org/omg/PortableServer/CurrentPackage/NoContext.java,v
retrieving revision 1.2
diff -u -r1.2 NoContext.java
--- org/omg/PortableServer/CurrentPackage/NoContext.java 2 Jul 2005 20:33:01 -0000 1.2
+++ org/omg/PortableServer/CurrentPackage/NoContext.java 14 Mar 2006 17:59:39 -0000
@@ -1,5 +1,5 @@
/* NoContext.java --
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -53,7 +53,7 @@
*
* @author Audrius Meskauskas, Lithiania ([EMAIL PROTECTED])
*/
-public class NoContext
+public final class NoContext
extends UserException
implements IDLEntity, Serializable
{
