Hi, The knopflerfish failure we were seeing was because the testsuite explicitly tried to get a NullPointerException by feeding BasicPermission a null argument to the constructor. We used to throw that, but when cleaning up the code this exception was no longer thrown. This fixes that:
2006-03-17 Mark Wielaard <[EMAIL PROTECTED]>
* java/security/BasicPermission.java (BasicPermission): Check
name equals empty string to force NullPointerException.
I also added a couple of Mauve tests for this.
Committed,
Mark
Index: java/security/BasicPermission.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/security/BasicPermission.java,v
retrieving revision 1.15
diff -u -r1.15 BasicPermission.java
--- java/security/BasicPermission.java 2 Jul 2005 20:32:40 -0000 1.15
+++ java/security/BasicPermission.java 17 Mar 2006 10:53:11 -0000
@@ -1,5 +1,6 @@
/* BasicPermission.java -- implements a simple named permission
- Copyright (C) 1998, 1999, 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
+ Copyright (C) 1998, 1999, 2002, 2003, 2004, 2005, 2006
+ Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -97,7 +98,7 @@
// requirement exists in the specification and Sun's runtime
// doesn't appear to do it.
- if ("".equals(name))
+ if (name.equals(""))
throw new IllegalArgumentException("Empty name");
}
signature.asc
Description: This is a digitally signed message part
