Hi Mark

> On Sun, 2006-03-19 at 20:58 +0100, Roman Kennke wrote:
> > The solution is of course to use a plain
> > JDialog that's made modal by calling setModal(true).
> 
> That is what your Changelog entry says. But not what your patch does.
> setModal() is not used in your patch anymore.

Indeed. I call the JDialog constructor with the modal flag set to true.
Sorry for that little mistake.


> > 2006-03-19  Roman Kennke  <[EMAIL PROTECTED]>
> > 
> >         * javax/swing/JColorChooser.java
> >         (createDialog): Create JDialog instead of ModalDialog. Make this
> >         dialog modal by calling setModal(true).
> >         (ModalDialog): Removed unnecessary inner class.
> 
> There is also a package private static method makeModal() that isn't
> used anymore after this patch. Should probably be removed also.

You are right. I'll fix this.

Cheers, Roman

-- 
“Improvement makes straight roads, but the crooked roads, without
Improvement, are roads of Genius.” - William Blake

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Reply via email to