hello there,

the jarsigner specs state that the user will be asked for the keystore 
password if one was not provided on the command line.  the attached 
patch --already committed-- ensures this is the case.

the ChangeLog entry is:

2006-03-26  Raif S. Naffah  <[EMAIL PROTECTED]>

        * tools/gnu/classpath/tools/jarsigner/Main.java (setupSigningParams):
        Ask user for keystore password if one was not provided.


cheers;
rsn
Index: Main.java
===================================================================
RCS file: /cvsroot/classpath/classpath/tools/gnu/classpath/tools/jarsigner/Main.java,v
retrieving revision 1.1
diff -u -r1.1 Main.java
--- Main.java	25 Mar 2006 12:38:20 -0000	1.1
+++ Main.java	26 Mar 2006 05:25:16 -0000
@@ -329,7 +329,16 @@
     else
       store = KeyStore.getInstance(ksType);

-    if (ksPassword != null)
+    if (ksPassword == null)
+      {
+        // ask the user to provide one
+        CallbackHandler handler = new ConsoleCallbackHandler();
+        PasswordCallback pcb = new PasswordCallback("Enter keystore password: ",
+                                                    false);
+        handler.handle(new Callback[] { pcb });
+        ksPasswordChars = pcb.getPassword();
+      }
+    else
       ksPasswordChars = ksPassword.toCharArray();

     URL url = new URL(ksURL);

Attachment: pgpHpYcUKcBFJ.pgp
Description: PGP signature

Reply via email to