hello Michael, On Sunday 26 March 2006 19:56, Michael Koch wrote: > On Sun, Mar 26, 2006 at 04:08:30PM +1100, Raif S. Naffah wrote: > > +# -* bash *- > > + > > +java gnu.classpath.tools.jarsigner.Main $@ > > You should add a a shebang line to this file: > > #!/bin/sh
i don't think so. the .sh file is the template. have a look at the
lines staring with:
bin_SCRIPTS = jarsigner
in the (patched) Makefile.am. the real script will end up being
"jarsigner" with no extension.
> The questions is if we should hardcode "java" or better check for a
> java executable in configure.ac and use $(JAVA) in the script.
agreed. the .sh template is not a working one. i doubt even if the
${JAVA}, whatever it is going to end up, will even find the tools.zip
and the classpath classes. more work is needed here.
> > Index: configure.ac
> > ===================================================================
> > RCS file: /cvsroot/classpath/classpath/configure.ac,v
> > retrieving revision 1.139
> > diff -u -r1.139 configure.ac
> > --- configure.ac 10 Mar 2006 01:36:10 -0000 1.139
> > +++ configure.ac 26 Mar 2006 04:59:44 -0000
> > @@ -248,6 +248,8 @@
> > AC_PROG_CC
> > AC_PROG_CPP
> >
> > +AC_PATH_PROGS(BASH, bash sh)
>
> I think we can depend on the fact that a posix compatible shell is
> installed on the system when configure can be run. And there is no
> need to depend on bash. We need no bashisms.
noted.
> BTW: Its good that you start this discussion now as I soon want to
> import my policytool replacement. ;-)
excellent!
thanks for the comments + cheers;
rsn
pgpjZ6bRkSDUB.pgp
Description: PGP signature
