On Thu, 2006-03-30 at 17:44 +0200, Mark Wielaard wrote:
> On Wed, 2006-03-29 at 23:41 +0200, Mark Wielaard wrote:
> > OK, here it is. I need to test it some more, clean it up and write a
> > proper ChangeLog entry. But it seems robust and to perform OK. At least
> > not worse then what we currently have. It also cleans up the code a bit
> > (imho). If you could take a look and/or try it out on something nasty
> > that would be appreciated.
> 
> I tested it some more and found one bug. We need to update the menubar
> width of a Frame if it contains one. That has been added. Also tried
> against hsqldb DataBase Manager and MegaMek and both seem to work as
> before.
> 
> 2006-03-30  Mark Wielaard  <[EMAIL PROTECTED]>
> 
>     PR 23527
>     * java/awt/Window.java (dispatchEventImpl): On ComponentEvents
>     adjust bounds. On resize invalidate and validate container.
>     Always pass on ComponentEvents to Container super class.
>     * gnu/java/awt/peer/gtk/GtkFramePeer.java (setBounds): Adjust for
>     menuBar and pass to GtkWindowPeer super class.
>     (postConfigureEvent): Adjust menu bar width. Adjust y and height
>     bounds and pass to GtkWindowPeer super class.
>     * gnu/java/awt/peer/gtk/GtkWindowPeer.java (x, y, width, height):
>     New fields for local bounds.
>     (getX, getY): New methods.
>     (getWidth): Don't call into awtComponent.
>     (getHeight): Likewise.
>     (create): Cache local bounds.
>     (setLocation): Documented, made protected and just call
>     nativeSetLocation.
>     (setLocationUnlocked): Removed unused method.
>     (setBoundsUnlocked): Likewise.
>     (setBounds): Check whether bounds actually changed and cache local
>     bounds.
>     (setSize): Documented and made protected.
>     (setResizable): Documented and cache local bounds.
>     (postConfigureEvent): Update local bounds. Don't call awtComponent
>     directly but post ComponentEvents.
>     (show): Cache local bounds.
>     (getBounds): Override to return cached bounds.
> 
> What do you think?

Looks great.  Please commit.

Thanks,
Tom



Reply via email to