On Tue, 2006-04-04 at 09:43 +0200, Wolfgang Baer wrote:
> Hi,
>
> Thomas Fitzsimmons wrote:
> [...]
> > +public class JPEGImageWriteParam
> > + extends ImageWriteParam
> > +{
>
> > +
> > + /**
> > + * Localized messages are stored in separate files.
> > + */
> > + private static ResourceBundle messages;
> > +
> [...]
> > + * @param locale the locale used for message localization
> > + */
> > + public JPEGImageWriteParam(Locale locale)
> > + {
> > + super(locale);
> > +
> > + // Get localized compression type and compression quality
> > + // description strings for the given locale.
> > + messages = PropertyResourceBundle.getBundle
> > + ("javax/imageio/plugins/jpeg/MessagesBundle", locale);
>
> As the messages variable is static a subsequent object construction
> with a different locale will change the messages of other instances.
> I think messages should be an instance variable here ?
Yes, good catch. Fix committed.
Tom
2006-04-04 Thomas Fitzsimmons <[EMAIL PROTECTED]>
* javax/imageio/plugins/jpeg/JPEGImageWriteParam.java (messages):
Remove static modifier.
Index: javax/imageio/plugins/jpeg/JPEGImageWriteParam.java
===================================================================
RCS file: /sources/classpath/classpath/javax/imageio/plugins/jpeg/JPEGImageWriteParam.java,v
retrieving revision 1.1
diff -u -r1.1 JPEGImageWriteParam.java
--- javax/imageio/plugins/jpeg/JPEGImageWriteParam.java 4 Apr 2006 00:49:51 -0000 1.1
+++ javax/imageio/plugins/jpeg/JPEGImageWriteParam.java 4 Apr 2006 13:43:17 -0000
@@ -70,7 +70,7 @@
/**
* Localized messages are stored in separate files.
*/
- private static ResourceBundle messages;
+ private ResourceBundle messages;
/**
* Construct a JPEGImageWriteParam with the following state: tiling
