On Tue, 2006-04-04 at 12:37 +0100, Gary Benson wrote: > Mark Wielaard wrote: > > Do note that with that define you will end up using 3 * 4K for each > > toCanonicalForm() operation. > > Will that be a problem do you think?
The current code is wrong and seems to allocate a lot of temporary objects. So your new code is an improvement. It just seems a bit much for this operation. Especially since I assume this is normally called on absolute paths that are already in canonical form. You can try to optimize it a bit. On the other hand it is clearly a good idea to have a good implementation now first and optimize later. Cheers, Mark
signature.asc
Description: This is a digitally signed message part
