Hi, this looks fine to me. Please commit. cya Robert
Carsten Neumann wrote: > My copyright assignment should be on file now, please comment > and/or commit ;) > > Thanks, > Carsten > > Carsten Neumann wrote: > >> Hi Mark, >> >>Mark Wielaard wrote: >> >> >>>Hi Casten, >>> >>>On Fri, 2006-03-24 at 23:52 +0100, Carsten Neumann wrote: >>> >>> >>>>I've implemented the method: public boolean isActive(). >>> >>> >>> >>>Nice. Useful method also. Last time I worked with the DefaultCaret I was >>>confused there wasn't such a method. I see this was added in 1.5. Could >>>you add a @since 1.5. >> >> >>see attached new version of patch. >> >> >>>>Please also note that my copyright assignment is pending, but the >>>>process has been started. >>> >>> >>> >>>Please send a ping (reply to this message on the list) when that is done >>>so we don't forget. >> >> >>will do. >> >> >>>Just one tiny nitpick. >>> >>>+ if(blinkTimer != null) >>>+ return blinkTimer.isRunning(); >>> >>>if normally has a space after it: >>> if (blinkTimer != null) >>> >>>Although I admit that this is not always precisley followed. But please >>>see http://www.gnu.org/software/classpath/docs/hacking.html#SEC6 >>>Seeing you followed the other guidelines there I assume you have read >>>that already :) >> >> >>Oops, that one slipped through, sorry, fixed. >> >> Thanks, >> Carsten >> >> >>------------------------------------------------------------------------ >> >>Index: DefaultCaret.java >>=================================================================== >>RCS file: /sources/classpath/classpath/javax/swing/text/DefaultCaret.java,v >>retrieving revision 1.36 >>diff -u -r1.36 DefaultCaret.java >>--- DefaultCaret.java 23 Mar 2006 21:17:22 -0000 1.36 >>+++ DefaultCaret.java 25 Mar 2006 15:46:15 -0000 >>@@ -1030,6 +1030,24 @@ >> } >> >> /** >>+ * Returns <code>true</code> if this <code>Caret</code> is blinking, >>+ * and <code>false</code> if not. The returned value is independent of >>+ * the visiblity of this <code>Caret</code> as returned by [EMAIL >>PROTECTED] #isVisible()}. >>+ * >>+ * @return <code>true</code> if this <code>Caret</code> is blinking, >>+ * and <code>false</code> if not. >>+ * @see #isVisible() >>+ * @since 1.5 >>+ */ >>+ public boolean isActive() >>+ { >>+ if (blinkTimer != null) >>+ return blinkTimer.isRunning(); >>+ >>+ return false; >>+ } >>+ >>+ /** >> * Returns <code>true</code> if this <code>Caret</code> is currently >> visible, >> * and <code>false</code> if it is not. >> * > > > > >
signature.asc
Description: OpenPGP digital signature
