On Tue, 2006-04-25 at 20:47 +0200, Audrius Meskauskas wrote:
> Lillian Angel wrote:
> 
> >Sorry for sending another email :( Here are all the problems I see with
> >the swing tree demo:
> >
> >- Every time you click new element, the tree should be repainted
> >instantly to see the new element. This happens when you add an element
> >to an expanded directory.

Sorry, I think i worded that wrong. In the swing demo, if you click the
"NEW ELEMENT" button, the tree should repaint.

> >  
> >
> I am not sure if I understand. How can I click an element if I do not 
> see it on the screen?
> If I already see it on the screen, why should it be repainted?
> 
> >- The selection rectangle around the node is too small
> >  
> >
> Yes.
> 
> >- The key listener does not work properly. I.e. expanding/collapsing
> >nodes with the left and right keys.
> >  
> >
> For me, the left key collapses the current tree branch, and the right 
> key expands the current node.
> It looks same as in the Sun's implementation. Some time age the left key 
> was not collapsing the
> branch (just selecting the parent node), but this disappeared as the 
> side effect of the other changes.

Hmm, It doesnt seem right in the demo. I'll try to update again.

> 
> >- The editing does not work well. The cursor does not appear when
> >editing is activated (only on triple click this is broken). If you click
> >on another node to cancel editing, the changes are made to that node you
> >click on and the original name for that node is changed. 
> >  
> >
> Yes. I did not noticed this because I was always testing the editing 
> with click - pause - click or
> with the F2 key.
> 
> >- Location of the editing cell is a bit off.
> >- The padding around the cells/icons/lines is non-existant.
> >  
> >
> Probably yes.
> 
> >- control icons are painted behind the lines.
> >  
> >
> Fixed today.
> 
> >- Sometimes the anchor is not shown on the node selected.
> >
> >Your work on JTree/BasicTreeUI has been really good. I am sure you are
> >still working on this, but I thought you would be interested in knowing
> >the remaining aesthetic issues.
> >
> >Lillian
> >
> >  
> >
> Best wishes.
> Audrius.

Lillian

> 
> 
> 


Reply via email to