>>>>> "Raif" == Raif S Naffah <[EMAIL PROTECTED]> writes:
Raif> the attached patch proposes the addition of the two security tools Raif> (jarsigner and keytool) to the tools.zip plus the generation of two Raif> convenience scripts to launch them. I have a couple nits on the Makefile. Otherwise I think this is great. Raif> +jarsigner: $(srcdir)/jarsigner.sh Raif> + mkdir -p $(bindir) Raif> + rm -f $(bindir)/jarsigner Raif> + cat $(srcdir)/jarsigner.sh > $(bindir)/jarsigner This puts jarsigner into bindir -- but this is wrong since this rule is only for building the tool. (Prematurely installing it means that DISTDIR won't be respected... most folks don't set this during the build itself.) Instead it should just go in '.'. Also using cat is a bit odd, why not just use 'cp'? Tom
