[cp-patches] FYI: Remove unnecessary ThreadGroup access checks

[Gary Benson]

Hi all,

This commit removes some unnecessary ThreadGroup access checks
that were happening during Thread and ThreadGroup access checks.
This fixes the failures in the Mauve tests I committed earlier
today.

Cheers,
Gary

Index: ChangeLog
===================================================================
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.7348
diff -u -r1.7348 ChangeLog
--- ChangeLog   10 May 2006 10:15:44 -0000      1.7348
+++ ChangeLog   10 May 2006 13:54:03 -0000
@@ -1,3 +1,11 @@
+2006-05-10  Gary Benson  <[EMAIL PROTECTED]>
+
+       * java/lang/ThreadGroup.java (parent): Make package-private.
+       * java/lang/SecurityManager.java (checkAccess(Thread)):
+       Reference ThreadGroup.parent directly to avoid extra checks.
+       * java/lang/SecurityManager.java (checkAccess(ThreadGroup)):
+       Likewise.
+
 2006-05-10  Roman Kennke <[EMAIL PROTECTED]>
 
        Reported by Ingo Proetel ([EMAIL PROTECTED])
Index: java/lang/ThreadGroup.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/ThreadGroup.java,v
retrieving revision 1.20
diff -u -r1.20 ThreadGroup.java
--- java/lang/ThreadGroup.java  12 Apr 2006 12:04:18 -0000      1.20
+++ java/lang/ThreadGroup.java  10 May 2006 13:54:03 -0000
@@ -66,7 +66,7 @@
   static boolean had_uncaught_exception;
 
   /** The parent thread group. */
-  private final ThreadGroup parent;
+  final ThreadGroup parent;
 
   /** The group name, non-null. */
   final String name;
Index: java/lang/SecurityManager.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/SecurityManager.java,v
retrieving revision 1.33
diff -u -r1.33 SecurityManager.java
--- java/lang/SecurityManager.java      10 Jan 2006 12:18:09 -0000      1.33
+++ java/lang/SecurityManager.java      10 May 2006 13:54:03 -0000
@@ -421,7 +421,7 @@
   public void checkAccess(Thread thread)
   {
     if (thread.getThreadGroup() != null 
-       && thread.getThreadGroup().getParent() == null)
+       && thread.getThreadGroup().parent == null)
       checkPermission(new RuntimePermission("modifyThread"));
   }
 
@@ -454,7 +454,7 @@
    */
   public void checkAccess(ThreadGroup g)
   {
-    if (g.getParent() == null)
+    if (g.parent == null)
       checkPermission(new RuntimePermission("modifyThreadGroup"));
   }