On Mon, 2006-05-01 at 16:39 -0400, Lillian Angel wrote:
> After testing a timezone app, I noticed that SimpleTimeZone is a little
> buggy. I fixed it up a bit... I imagine there are more bugs in this
> code. It does work better now.
> 
> 2006-05-01  Lillian Angel  <[EMAIL PROTECTED]>
> 
>         * java/util/SimpleTimeZone.java
>         (SimpleTimeZone): Do not throw exception if startMonth == 
>       endMonth.
>         (SimpleTimeZone): Likewise.
>         (checkRule): Rewritten to properly check all values (more 
>       efficently).
>         This code is now more stable, at least less buggy than before. 
>       Fixed API documentation.
>         (setStartRule): Moved checkRule call to end.
>         (setStartRule): Likewise.
>         (setEndRule): Likewise.
>         (setEndRule): Likewise.

This introduced a mauve regression:

FAIL: gnu.testlet.java.util.SimpleTimeZone.constructors: uncaught exception at 
"(int, String, int, int, int, int, int, int, int, int)" number 7: 
java.lang.ArrayIndexOutOfBoundsException: 12
java.lang.ArrayIndexOutOfBoundsException: 12
   at java.util.SimpleTimeZone.getDaysInMonth(SimpleTimeZone.java:788)
   at java.util.SimpleTimeZone.checkRule(SimpleTimeZone.java:449)
   at java.util.SimpleTimeZone.setEndRule(SimpleTimeZone.java:577)
   at java.util.SimpleTimeZone.<init>(SimpleTimeZone.java:335)
   at 
gnu.testlet.java.util.SimpleTimeZone.constructors.testConstructor2(constructors.java:103)
   at 
gnu.testlet.java.util.SimpleTimeZone.constructors.test(constructors.java:41)
   at gnu.testlet.SimpleTestHarness.runtest(SimpleTestHarness.java:260)
   at gnu.testlet.SimpleTestHarness.main(SimpleTestHarness.java:413)
1 of 10 tests failed

Could you take a look please.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to