[cp-patches] Patch: BasicMenuUI

[Lillian Angel]

Implemented some missing functions to make JAPI a little happier. I
marked a couple of functions as unimplemented, as well.

2006-07-04  Lillian Angel  <[EMAIL PROTECTED]>

        * javax/swing/plaf/basic/BasicMenuUI.java
        (installKeyboardActions): Implemented to call super. Nothing 
        else needs to be done here.
        (setupPostTimer): Marked as unimplemented.
        (uninstallKeyboardActions): Implemented to call super. Nothing 
        else needs to be done here.
        (mouseMoved): Removed TODO. Nothing to be done here.
        (ChangeHandler): Implemented.
        (menuDragMouseExited): Removed TODO. Nothing to be done here.
        (menuDragMouseReleased): Removed TODO. Nothing to be done here.
        (menuKeyReleased): Removed TODO. Nothing to be done here.
        (menuKeyTyped): Marked as unimplemented.

Index: javax/swing/plaf/basic/BasicMenuUI.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicMenuUI.java,v
retrieving revision 1.24
diff -u -r1.24 BasicMenuUI.java
--- javax/swing/plaf/basic/BasicMenuUI.java	21 Jun 2006 13:13:40 -0000	1.24
+++ javax/swing/plaf/basic/BasicMenuUI.java	4 Jul 2006 16:11:55 -0000
@@ -220,9 +220,8 @@
    *
    */
   protected void installKeyboardActions()
-    throws NotImplementedException
   {
-    // FIXME: Need to implement
+    super.installKeyboardActions();
   }
 
   /**
@@ -235,6 +234,7 @@
   }
 
   protected void setupPostTimer(JMenu menu)
+  throws NotImplementedException
   {
     // TODO: Implement this properly.
   }
@@ -263,9 +263,8 @@
    * Basic look and feel's defaults.
    */
   protected void uninstallKeyboardActions()
-    throws NotImplementedException
   {
-    // FIXME: Need to implement
+    super.installKeyboardActions();
   }
 
   /**
@@ -348,7 +347,7 @@
 
     public void mouseMoved(MouseEvent e)
     {
-      // TODO: What should be done here, if anything?
+      // Nothing to do here.
     }
 
     public void mousePressed(MouseEvent e)
@@ -469,7 +468,8 @@
      */
     public ChangeHandler(JMenu m, BasicMenuUI ui)
     {
-      // Not used.
+      menu = m;
+      this.ui = ui;
     }
 
     /**
@@ -517,7 +517,7 @@
      */
     public void menuDragMouseExited(MenuDragMouseEvent e)
     {
-      // TODO: What should be done here, if anything?
+      // Nothing to do here.
     }
 
     /**
@@ -528,7 +528,7 @@
      */
     public void menuDragMouseReleased(MenuDragMouseEvent e)
     {
-      // TODO: What should be done here, if anything?
+      // Nothing to do here.
     }
   }
 
@@ -545,7 +545,7 @@
      */
     public void menuKeyPressed(MenuKeyEvent e)
     {
-      // TODO: What should be done here, if anything?
+      // Nothing to do here.
     }
 
     /**
@@ -555,7 +555,7 @@
      */
     public void menuKeyReleased(MenuKeyEvent e)
     {
-      // TODO: What should be done here, if anything?
+      // Nothing to do here.
     }
 
     /**
@@ -565,6 +565,7 @@
      * @param e A [EMAIL PROTECTED] MenuKeyEvent}.
      */
     public void menuKeyTyped(MenuKeyEvent e)
+    throws NotImplementedException
     {
       // TODO: What should be done here, if anything?
     }