Mario Torre wrote:
Hi!

I've checked this twice, but given the kind of update I suggest to give
another look at it, so this is also a RFA.

This release contains a couple of fixes, most important it adds explicit
tests in the GConf native layer so that an invalid key does not results
in a crash.
I have added also some new javadoc comments and fixed some old ones.
I have also updated the default path for user nodes from /apps/java
to /apps/classpath.

If you think this is fine, please commit for me, as I don't have write
access to the CVS.

This looks good.  We should probably get you commit access.  Just one comment:

-static jclass get_jlist_reference (JNIEnv *env, jclass jlist_class);
+static jclass get_jlist_reference (JNIEnv * env, jclass jlist_class);

Why did you change the formatting here?  GNU style is JNIEnv *env.

Tom

Reply via email to