On Mon, 2006-07-10 at 21:08 -0700, Casey Marshall wrote:
> Looks fine, just lines like these
>
> > - String ls = SystemProperties.getProperty("line.separator");
> > + String ls = (String) AccessController.doPrivileged(new
> > GetPropertyAction(
> > +
> > "line.separator"));
>
> should be on one line (Eclipse did this, I bet).
>
> When there are are long lines without "good" places to break, I tend
> to break before an opening parenthesis, or before a period. Something
> like this:
>
> String ls = (String) AccessController.doPrivileged
> (new GetPropertyAction("line.separator"));
Yeah that was eclipse's fault. Took your advice and mimicked your
approach. The patch has been committed.
Thanks,
Vivek
