>>>>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes:

Tom> The problem is that Inflater requires an extra dummy byte when
Tom> created with the "no header" flag.  This patch arranges to pass
Tom> in this byte when reading from a zip file.

Just to clarify -- you might think that this is somehow fixable in the
InflaterInputStream.  It really isn't, because the InflaterInputStream
decides when to call fill(), and it has no way of knowing that the
Inflater needs an extra byte.

This could be fixed in zlib, of course -- after all that is what
Classpath implicitly did.  However, I did not want to venture there,
especially as it would (most likely) mean maintaining a zlib fork.

If you look around a bit with google you'll see that other existing
users of Inflater have to do this same kind of thing.  In fact I found
an instance in ant which, coincidentally, looks almost exactly the
same as my patch against 4.1.

Tom

Reply via email to