The FocusAction class in BasicMenuBarUI should really be static, because it's shared between all UI instances and must not access instance methods and fields.

2006-07-26  Roman Kennke  <[EMAIL PROTECTED]>

        * javax/swing/plaf/basic/BasicMenuBarUI.java
        (FocusAction): Made class static.

/Roman
Index: javax/swing/plaf/basic/BasicMenuBarUI.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicMenuBarUI.java,v
retrieving revision 1.17
diff -u -1 -2 -r1.17 BasicMenuBarUI.java
--- javax/swing/plaf/basic/BasicMenuBarUI.java	25 Jul 2006 11:10:44 -0000	1.17
+++ javax/swing/plaf/basic/BasicMenuBarUI.java	26 Jul 2006 07:50:03 -0000
@@ -66,25 +66,25 @@
 import javax.swing.plaf.ComponentUI;
 import javax.swing.plaf.MenuBarUI;
 
 /**
  * UI Delegate for JMenuBar.
  */
 public class BasicMenuBarUI extends MenuBarUI
 {
 
   /**
    * This action is performed for the action command 'takeFocus'.
    */
-  private class FocusAction
+  private static class FocusAction
     extends AbstractAction
   {
 
     /**
      * Creates a new FocusAction.
      */
     FocusAction()
     {
       super("takeFocus");
     }
 
     /**

Reply via email to