Hi Tom,

On Fri, 2006-07-28 at 19:41 -0400, Thomas Fitzsimmons wrote:
> I committed this patch to make the peer libraries versionless.  This is good 
> practice for dlopen'd libraries.  In the case of libjawt.so which is meant to 
> be 
> linked to, making it versionless gives it the SONAME of "libjawt.so", which 
> makes it binary compatible with Sun's library.

> 2006-07-28  Thomas Fitzsimmons  <[EMAIL PROTECTED]>
> 
>       * native/jawt/Makefile.am (libjawt_la_LDFLAGS): Add
>       -avoid-version.
>       * native/jni/gtk-peer/Makefile.am (libgtkpeer_la_LDFLAGS):
>       Likewise.
>       * native/jni/midi-alsa/Makefile.am (libgjsmalsa_la_LDFLAGS):
>       Likewise.
>       * native/jni/midi-dssi/Makefile.am (libgjsmdssi_la_LDFLAGS):
>       Likewise.

There was no patch attached (done so now). Also, would you recommend
this for the release branch?

Thanks,

Mark
Index: native/jni/midi-dssi/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/midi-dssi/Makefile.am,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- native/jni/midi-dssi/Makefile.am	10 Mar 2006 01:36:10 -0000	1.6
+++ native/jni/midi-dssi/Makefile.am	28 Jul 2006 23:37:11 -0000	1.7
@@ -5,6 +5,7 @@
 			 dssi_data.h
 
 libgjsmdssi_la_LIBADD = $(top_builddir)/native/jni/classpath/jcl.lo -ljack
+libgjsmdssi_la_LDFLAGS = -avoid-version
 
 AM_LDFLAGS = @CLASSPATH_MODULE@
 AM_CPPFLAGS = @CLASSPATH_INCLUDES@ 
Index: native/jni/midi-alsa/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/midi-alsa/Makefile.am,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- native/jni/midi-alsa/Makefile.am	10 Mar 2006 01:36:10 -0000	1.3
+++ native/jni/midi-alsa/Makefile.am	28 Jul 2006 23:37:11 -0000	1.4
@@ -5,6 +5,7 @@
 gnu_javax_sound_midi_alsa_AlsaMidiDeviceProvider.c
 
 libgjsmalsa_la_LIBADD = -lasound
+libgjsmalsa_la_LDFLAGS = -avoid-version
 
 AM_LDFLAGS = @CLASSPATH_MODULE@
 AM_CPPFLAGS = @CLASSPATH_INCLUDES@ `pkg-config  --cflags-only-I alsa`
Index: native/jni/gtk-peer/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/gtk-peer/Makefile.am,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -r1.48 -r1.49
--- native/jni/gtk-peer/Makefile.am	17 Jul 2006 18:37:20 -0000	1.48
+++ native/jni/gtk-peer/Makefile.am	28 Jul 2006 23:37:11 -0000	1.49
@@ -51,6 +51,7 @@
 
 libgtkpeer_la_LIBADD = $(top_builddir)/native/jni/classpath/native_state.lo \
 		       $(top_builddir)/native/jni/classpath/jcl.lo
+libgtkpeer_la_LDFLAGS = -avoid-version
 
 AM_LDFLAGS = @CLASSPATH_MODULE@ @GTK_LIBS@ @FREETYPE2_LIBS@ \
              @PANGOFT2_LIBS@ @X_PRE_LIBS@ @X_LIBS@ @X_EXTRA_LIBS@ @XTEST_LIBS@
Index: native/jawt/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jawt/Makefile.am,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- native/jawt/Makefile.am	7 Jun 2006 21:15:43 -0000	1.7
+++ native/jawt/Makefile.am	28 Jul 2006 23:37:11 -0000	1.8
@@ -2,6 +2,7 @@
 
 libjawt_la_SOURCES = jawt.c
 libjawt_la_LIBADD = $(top_builddir)/native/jni/gtk-peer/libgtkpeer.la
+libjawt_la_LDFLAGS = -avoid-version
 
 AM_LDFLAGS = @CLASSPATH_MODULE@ @GTK_LIBS@ @PANGOFT2_LIBS@ @X_LIBS@ @XTEST_LIBS@
 AM_CPPFLAGS = @CLASSPATH_INCLUDES@

Reply via email to