>>>>> "Raif" == Raif S Naffah <[EMAIL PROTECTED]> writes:

Raif> 2006-08-06  Raif S. Naffah  <[EMAIL PROTECTED]>
Raif>   PR Classpath/27372
Raif>   * java/math/BigInteger.java: Updated copyright year.
Raif>   (init): Consume as little bytes as possible.

This looks reasonable... one nit below.

Raif> a new Mauve test
Raif> gnu/testlet/java/math/BigInteger/TestOfPR27372.java has been
Raif> added to highlight the problem and validate the fix.

BTW -- thanks for writing the regression tests.

Raif> +    byte[] highBitBytes = new byte[highBitByteCount];
Raif>      if (highbits > 0)
Raif> -      highbits = rnd.nextInt() >>> (32 - highbits);
Raif> +      {

highBitBytes is only used in the 'if' -- so it would be better to move
the allocation into this block.

Tom

Reply via email to