Casey Marshall wrote: > > - Instead of changing > FileInputStream/FileOutputStream/RandomAccessFile, > > FileChannelImpl should accommodate them. > > I'm not sure what you mean by this.
It just looked like unnecessary code duplication. If FileChannelImpl.create throws the right exception, the others don't need to do the exception conversion. Also, if the ByteBuffer wrapping happens in FileChannelImpl, it'll be easier for me te remove it in my FileChannelImpl ;-) > > - PlainSocketImpl.write(byte[],int,int) implementation is > > unacceptable. > > OK. I don't think that method is needed any more, though. The output > stream calls on the channel directly. Ah yes, I missed that. Well it that case it can be removed, even better ;-) Regards, Jeroen
