Mario Torre wrote:
Il giorno mar, 26/09/2006 alle 11.53 -0400, Thomas Fitzsimmons ha
scritto:
Hi,
Mario Torre wrote:
Il giorno dom, 24/09/2006 alle 21.09 +0200, Mario Torre ha scritto:
Thomas Fitzsimmons kindly reviewed my patch on #classpath.
As a result, this a little update (hope I'm not missing something,
please let me know in this case).
I have removed the call to g_strdup_printf completely, I assume that it
is safe, as gconf_escape_key already returns a newly allocate and
stripped string.
You're still using g_strdup_printf here:
ops... sorry, I was sleeping...
Since you're not freeing _val, this is a memory leak.
Tom
This should fix it, I have also remove declarations outside the while
loop, though I think gcc already optimize this.
Waiting for news... :)
Yup, looks good now. Please commit.
Tom
