hello Jeroen, On Sunday 08 October 2006 22:44, Jeroen Frijters wrote: > Hi Raif, > > The synchronization is still not completely right. If a method operates > on two different BigIntegers, they both need to be protected from > asynchronous finalization. Note also that when you synchronize on two > different objects, you need to protect against deadlock.
noted.
> Also, could you please change USING_NATIVE into a final constant, so
> that VMs that set WANT_NATIVE_BIG_INTEGER to false don't get all that
> extra code? You can do that and still keep the fallback approach (if the
> native library is missing), by using the following pattern:
>
> private static final boolean USING_NATIVE =
> Configuration.WANT_NATIVE_BIG_INTEGER && initNative();
>
> private static boolean initNative()
> {
> // .. load library
> return success;
> }
ok.
cheers;
rsn
pgpDguMOU6mdK.pgp
Description: PGP signature
