Hi Roman,
Can you commit this patch after you fix p-implied? This patch removes all
the CP specific sections. Thanks!
David Fu.
> Hi David,
>
>> Thanks for checking the file in! The IMPLIED tag in the RI is
>> implemented
>> as a <p-implied> Tag with a NameAttribute of HTML.Tag.IMPLIED. GNU CP
>> implements it as a <p> Tag with a NameAttribute of HTML.Tag.P, with a
>> tag
>> attribute of _implied_="true".
>
> We should fix that. It sounds easy enough.
>
>> The other difference is that since the RI
>> is using HTML.Tag.IMPLIED, it is recognized as a Synthetic Tag. Whereas
>> the implementation of CP using HTML.Tag.P is not recognized as a
>> Synthetic
>> Tag.
>
> Indeed.
>
>> Yeah, it would be great if GNU CP can finally claim to be Mauve 1.4
>> "Wink
>> Wink" compatitble(MDK 1.4 perhaps?)!
>
> Yeah. We actually have almost everything there. The few missing pieces
> seem to be quite rarely used, maybe with the exception of the html
> package. Which is beeing worked on.
>
>> It will be able to statisfy many
>> application developers(me included) enough to give CP a try. I will
>> probably to hop over to the IRC this weekend ;)
>
> I'll be around!
>
> Cheers, Roman
>
>
>
--- /home/work/classpath_work/classpath/javax/swing/text/html/HTMLWriter.java 2006-10-31 20:30:24.000000000 +0900
+++ /home/work/classpath_work/my_work/src/javax/swing/text/html/HTMLWriter.java 2006-11-10 11:20:52.000000000 +0900
@@ -608,28 +608,8 @@
closeOutUnwantedEmbeddedTags(attrSet);
- // NOTE: 20061030 - fchoong - GNU CP uses a different implimentation of
- // the IMPLIED tag.
- boolean fg_gnu_cp_implied_tag = false;
-
- if (matchNameAttribute(attrSet, HTML.Tag.P))
- {
- //writeAllAttributes(attrSet);
-
- Enumeration attrNameEnum = attrSet.getAttributeNames();
-
- while (attrNameEnum.hasMoreElements())
- {
- Object key = attrNameEnum.nextElement();
- Object value = attrSet.getAttribute(key);
-
- if (key.equals("_implied_") && value.toString().equals("true"))
- fg_gnu_cp_implied_tag = true;
- } // while(attrNameEnum.hasMoreElements())
- } // if(matchNameAttribute(attrSet, HTML.Tag.P))
-
// handle the tag
- if (synthesizedElement(paramElem) || fg_gnu_cp_implied_tag)
+ if (synthesizedElement(paramElem))
{
if (matchNameAttribute(attrSet, HTML.Tag.CONTENT))
{
@@ -640,8 +620,7 @@
{
comment(currElem);
} // else if(matchNameAttribute(attrSet, HTML.Tag.COMMENT))
- else if (matchNameAttribute(attrSet, HTML.Tag.IMPLIED)
- || fg_gnu_cp_implied_tag) // NOTE: GNU CP specific
+ else if (matchNameAttribute(attrSet, HTML.Tag.IMPLIED))
{
int child_elem_count = currElem.getElementCount();
@@ -782,28 +761,8 @@
if (fg_is_fragment_parent_elem || (fg_pass_start_elem
&& fg_pass_end_elem == false) || fg_is_start_and_end_elem)
{
- // NOTE: 20061030 - fchoong - GNU CP uses a different implimentation of
- // the IMPLIED tag.
- boolean fg_gnu_cp_implied_tag = false;
-
- if (matchNameAttribute(attrSet, HTML.Tag.P))
- {
- //writeAllAttributes(attrSet);
-
- Enumeration attrNameEnum = attrSet.getAttributeNames();
-
- while (attrNameEnum.hasMoreElements())
- {
- Object key = attrNameEnum.nextElement();
- Object value = attrSet.getAttribute(key);
-
- if (key.equals("_implied_") && value.toString().equals("true"))
- fg_gnu_cp_implied_tag = true;
- } // while(attrNameEnum.hasMoreElements())
- } // if(matchNameAttribute(attrSet, HTML.Tag.P))
-
// handle the tag
- if (synthesizedElement(paramElem) || fg_gnu_cp_implied_tag)
+ if (synthesizedElement(paramElem))
{
if (matchNameAttribute(attrSet, HTML.Tag.CONTENT))
{
@@ -862,8 +821,7 @@
{
comment(currElem);
} // else if(matchNameAttribute(attrSet, HTML.Tag.COMMENT))
- else if (matchNameAttribute(attrSet, HTML.Tag.IMPLIED)
- || fg_gnu_cp_implied_tag) // NOTE: GNU CP specific
+ else if (matchNameAttribute(attrSet, HTML.Tag.IMPLIED))
{
int child_elem_count = currElem.getElementCount();
