On Nov 27, 2006, at 12:08 AM, Raif S. Naffah wrote:
On Sunday 26 November 2006 19:58, Casey Marshall wrote:
On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote:
On Tuesday 21 November 2006 08:35, Casey Marshall wrote:
...
This patch fixes an issue with JarEntry objects that are created
before the entry is verified...
...before your patch our
implementation outputs 0, 0, and 1, and after the patch: 1, 1, and
1 which is different in both cases.
Yeah, JarEntry needs to check if the entry has been verified first
before looking in the certificates map. Attached is an updated patch;
with it the TestOfManifest test passes.
yes. please update the copyright year of JarEntry when you check
in the
patch.
OK.
any reason why you didn't address the synchronization issue in
JarEntry#getCertificates()?
I wasn't sure if it was needed. I think when just reading the certs
mapping, it doesn't need to be (that map is created when the manifest
is read, and not modified after). But, the validity mapping probably
needs synchronized access. I'll look at it.
Thanks.
