Hi, On Tue, 2006-12-19 at 11:26 -0700, Tom Tromey wrote: > >>>>> "Mario" == Mario Torre <[EMAIL PROTECTED]> writes: > > I spoke too soon, sorry :( > > Mario> for (p = 0; > Mario> p < data.length && data[p].getType() == > ElementSpec.EndTagType; > Mario> - p++); > Mario> + p++) continue; > > Loops like this are idiomatic. Adding a 'continue' looks weird. > > FWIW I don't like the style of putting the ';' right after the closing > parenthesis. Instead I prefer to have the semicolon on its own line, > to emphasize that this is an intentionally empty statement. > > Any comments from other hackers?
O, o. Bikeshed ahead. But since you asked. I also don't like the style
of putting the ';' after the closing bracket. I don't mind the continue
though, I think it is a little more clear than just the ';' on a line
(and it it shorter than a whole { /* do nothing block */ }.
I would like to have a warning/error for empty statements since as Mario
showed those do hide bad/buggy code.
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part
