Mario Torre <neugens <at> limasoftware.net> writes: Ciao Mario,
The patch looks fine, I've got a a few small comments about the code: a) there is some uncommented code left over in cpio_checkAccess. b) The setReadable/Writeable/Executable functions should return JNI_FALSE rather than 0 on failure to convert the string. c) It seems like the set* functions only differ by the initial value of the permissions. In order to avoid duplicating the code, it would be better to write a helper function that receives the initial permission value, and delegate to it. cheers, dalibor topic
