>>>>> "Mario" == Mario Torre <[EMAIL PROTECTED]> writes:
Mario> This patch does not contains code, only configuration setups, Mario> and it is not meant to be committed. I need some feedback on Mario> that because I'm not a configure expert so it is highly Mario> probable that I've missed something. Looks pretty good to me. Mario> DIST_SUBDIRS = classpath java-io java-lang java-net java-nio java-util \ Mario> - gtk-peer gconf-peer qt-peer xmlj midi-alsa midi-dssi \ Mario> + gtk-peer gconf-peer gstreamer-peer qt-peer xmlj midi-alsa midi-dssi \ This looks like it may go past column 79... Mario> + dnl FIXME: this is pretty hight requirement, maybe it can be lowered Mario> + dnl moreover, we really need all these? Mario> + GST_MAJORMINOR=0.10 Mario> + GST_REQUIRED=0.10.10 I'd just delete the comment and require 0.10. But then, my OS already has that version :). Does some common OS not ship the right gstreamer? Mario> + dnl -fno-strict-aliasing -export-symbols-regex [_]*\(gst_\|Gst\|GST_\).* -fno-strict-aliasing is really for legacy code. New code should not need this -- just write correct C instead. (I know it is in a comment, I just didn't know why & I wanted to point that out.) Mario> +resource/META-INF/services/javax.sound.sampled.spi.AudioFileReader Mario> +resource/META-INF/services/javax.sound.sampled.spi.MixerProvider We talked a bit about not doing this... but I never replied to your note and now I forgot what you said. Do we need this? Or is there another way? Tom
