Andrew John Hughes wrote:
I noticed when trying to fix PR34840 that we have
a lot of duplicate code between StringBuffer and
StringBuilder.  This patch abstracts most of it
into a common superclass.  Testing PR34840 showed
that OpenJDK already does this.

PR21869 is also then trivial, as we just need an
additional Classpath string buffer that doesn't
create a copy when toString() is called (as in
GCJ).

Comments? I'll commit Monday if there are no
objections.


I don't object, however it might be interesting to know if this change would cause performance regressions on <your favorite vm here>. Other than that, it seems like a good idea.

David Daney

Reply via email to