On 03/03/2008, Dalibor Topic <[EMAIL PROTECTED]> wrote: > Christian Thalinger wrote: > > On Sun, 2008-03-02 at 02:08 +0000, Andrew John Hughes wrote: > >> This patch separates out common methods from the reflection VM > >> interfaces (Field, Constructor, Method) so that they are provided > >> in Classpath itself, and only native methods now appear in > >> new VMField, VMMethod and VMConstructor classes in the VM interface. > >> There is a lot of duplicate code in these classes that is currently > >> left to the VM to maintain, resulting in large parts of these files > >> in the VM being verbatim copies of the reference implementation and > >> dependent on package-private Classpath methods. > >> > >> Comments please. > > > > I think that is a very good idea, as these reflection class were the > > only ones without a VM-interface class. I'd like to have that in. > > > > > Yes, please. > > cheers, > > dalibor topic >
Committed. Thanks everyone. -- Andrew :-) Document Freedom Day - March 26th http://documentfreedom.org Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net