Andrew John Hughes wrote:
Looks okay, overlooking the obvious formatting issues.
Is there an overhead to the method call or would most VMs inline this?

So, most code shouldn't access an element beyond the length of the Vector or ArrayList - so the exception handling code will never normally be executed in any benchmarks, so the method calling overhead isn't important. If the method call were to become hot, the Jikes RVM would inline it, but this is very unlikely to happen. This patch is being applied against the Jikes RVM currently to gain performance in particular on SpecJVM 98. I'd like to include the patch in Classpath to minimize points where the Jikes RVM and Classpath libraries differ.

Thanks,
Ian

Reply via email to