On 22/05/2008, Joshua Sumali <[EMAIL PROTECTED]> wrote: > Hi, > > The following patch places the gjdoc source into the classpath tree, and > builds gjdoc into tools.zip. I tested this by first building and installing > classpath (make && sudo make install), then passing > --with-gjdoc=/usr/local/classpath/bin/gjdoc to ./configure, > as to generate javadoc on the second build. This works, but only if the > wrapper at /usr/local/classpath/bin/gjdoc has -Xmx512m -Xms512m as part of > the java flags, otherwise it will run out of memory while generating javadoc > for all of the classes. "-Xmx512m -Xms512m" could be default flags in > tools/gjdoc.in, but I don't know if this is an ideal solution. > > The patch is located at > http://icedtea.classpath.org/~jsumali/classpath-gjdoc.patch > (warning, 1.5MB), or > http://icedtea.classpath.org/~jsumali/classpath-gjdoc-patch.tar.gz > (233K). It should apply cleanly to what's in the classpath repo right now. > > Thanks, > Josh > >
Firstly, thanks very much for doing this. As I mentioned on the last release, this is something I and others wanted to happen, so thanks for doing the actual work to start us down that path. I'll try and have a look at the patch over the weekend. My initial fear is that something might have been lost in moving gjdoc over, because the build for it was a little more complicated than simply building the java files (which is the case for the other tools). Notably, gjdoc was built natively, and I'd like to see this generalised to Classpath for all tools. It gets rid of this memory problem you mention. On that subject, 512 is not enough on x86_64; I've had to go up to 768 before, and I've failed to build it on my old machine because of a lack of memory. Hence why I'd like to keep the native build as the optimum. -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8