I've reverted the return on chdir = -1.  The warning is still
fixed by assigning the result to a variable.  We should come
back to this after the release.

ChangeLog:

2009-02-04  Andrew John Hughes  <ahug...@redhat.com>

        * native/jni/native-lib/cpproc.c:
        (cpproc_forkAndExec): Don't return on a -1
        result from chdir as this may be valid in
        some cases.  A better fix is needed.

-- 
Andrew :)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
Index: native/jni/native-lib/cpproc.c
===================================================================
RCS file: /sources/classpath/classpath/native/jni/native-lib/cpproc.c,v
retrieving revision 1.5
diff -u -u -r1.5 cpproc.c
--- native/jni/native-lib/cpproc.c      4 Feb 2009 12:09:55 -0000       1.5
+++ native/jni/native-lib/cpproc.c      4 Feb 2009 14:09:47 -0000
@@ -87,8 +87,7 @@
       close_all_fds(local_fds, pipe_count * 2);
 
       i = chdir(wd);
-      if (i == -1)
-       return errno;
+      /* FIXME: Handle the return value */
       if (newEnviron == NULL)
        execvp(commandLine[0], commandLine);
       else

Reply via email to