Hi, Andrew! Is it possible to finally get commit access? It seems nobody else is willing to review and commit to. The patches were published at least 3 months ago and there is no pending questions or negative comments (from the interested parties) regarding them.
I'm also planning to create new patches (fixing bugs in Number/DateFormatter parsers) but if the patches are unlikely to be committed then there is little sense in submitting them. Regards. Tue, 01 Jun 2010 14:56:07 +0400 Ivan Maidanski <iv...@mail.ru>: > Hi! > Tue, 1 Jun 2010 11:32:25 +0100 Andrew John Hughes <ahug...@redhat.com>: > > On 21:22 Sat 29 May , Ivan Maidanski wrote: > > > Hello, Andrew! > > > > > > I've signed the copyright paper and also recently received it (with the > both signatures) via e-mail. > > > > > > What's the next step? > > > > > > > Hi Ivan. Yes, I saw the assignment come through as I finished work on > Friday. I need to finish > > looking through the remaining patches you posted. Once those are ok to go > back, I'll give you > > commit access to push them. > Ok. Thanks. This is NOT urgent. (Currently I've sent roughly 1/2 of patches > I've intended to submit, and the unsent party is a bit more complicated.) > > > > Please understand that with such power comes responsibility so please use it > wisely :-) > Ok. I've got experience in BoehmGC. > > > > > Thanks. > > > > > > Sun, 11 Apr 2010 23:56:53 +0100 Andrew John Hughes <ahug...@redhat.com>: > > > > > > > On 11:04 Sat 10 Apr , Ivan Maidanski wrote: > > > > > > > > > > Fri, 09 Apr 2010 18:13:42 +0200 Mark Wielaard <m...@klomp.org>: > > > > > > > > > > > On Thu, 2010-04-08 at 21:34 +0100, Andrew John Hughes wrote: > > > > > > > I need to speak to Mark about this process when he returns from > > > > > > > paternity leave. > > > > > > > > > > > > Still somewhat sleep deprived from handling the new family addition, > but > > > > > > I am reading email again. Sorry for any delays. > > > > > > > > > > > > > On 8 April 2010 14:01, Ivan Maidanski <iv...@mail.ru> wrote: > > > > > > > > I'd like to contribute patches for Classpath. I have a lot of > small bug fixes > > > > > > > > and minor code speed improvements (which I've collected over 5 > year), as well > > > > > > > > as some java generics has been added, and now I'd like to push > them all to the > > > > > > > > community - I've grouped the changes and prepared the patch > files (10 files, > > > > > > > > 450K overall) against the latest SVN. > > > > > > > > > > > > Wow, cool. The best course of action would be to send them, if at > all > > > > > > possible as separate patches to the classpath-patches@gnu.org > > > > > > mailinglist, so others can help get them reviewed and merged. > > > > > > > > > > Well, I could send them to the entitled email but AICS there is no > "others" getting them reviewed and merged (probably, because of JDK which > turned into OpenJDK). > > > > > > > > They still need to be posted. CC me and I'll make sure they get > reviewed. I already did so for one patch. > > > > > > > > > But I can't make every patch less than 15 lines. (So, if I understood > correctly, they hardly be merged to the trunk.) > > > > > > > > > > > > > This is 15 lines over all patches, not per patch i.e. anything more than > a trivial fix needs an assignment. > > > > > > > > > On the other hand, I could just send them to and forget about it, > because I can have a legal copy of Classpath on my side and patch it in any > way I like. > > > > > > > > > > > > > True. Though nice to contribute back if you can. > > > > > > > > > > > > > > > > As Andrew said the FSF would like to keep a record of all > contributions. > > > > > > Would you be willing to assign the copyright to the Free Software > > > > > > Foundation, so that we could add your patches to GNU Classpath? > > > > > > > > > > It seems to me (w/o yet looking into the "real papers"), I won't loose > anything if I assign. > > > > > > > > > > > > > Great. > > > > > > > > > > > > > > > > The FSF still a bit "old fashioned" and deals in "real paper" > records. > > > > > > They will send you a copy if you complete the attached request form > and > > > > > > send it, with as subject your full name to ass...@gnu.org (please CC > me > > > > > > and Andrew so we can keep track). The FSF will then sent you the > > > > > > appropriate papers (and possibly a company disclaimer if you do work > on > > > > > > company time or if your company can make claims on the work you do). > > > > > > > > > > Ok. Hope the FSF won't stay "old fashioned" forever. > > > > > > > > > > > > > > > > > Sorry for the bureaucracy. Except for this paperwork stuff we are a > very > > > > > > relaxed bunch of hackers. I hope you like working with the team. > > > > > > > > > > Good. But, it looks like that the team is not quite free in hearing a > 3rd-party opinion expressed in code terms. (At least, the Eclipse team never > said me "we can't process your patches w/o signing a paper".) > > > > > > > > > > > > > Which puts them in an interesting position if they ever have to defend > > > > a claim against all that code as it will have a huge number of > > > > copyright holders, some of which may not be contactable any more. By > > > > assigning code to the FSF, they can defend any claims against it. And > > > > once it's done, it's done for all GNU Classpath patches. > > > > > > > > > > > > > > Anyway, Thank you much for the invitation, I'll fill and submit the > request. > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Mark Wielaard > > > > > > GNU Classpath Maintainer > > > > > > > > > > > > Please email the following information to ass...@gnu.org, and we > will > > > > > > send you the assignment form that covers the changes you have > already > > > > > > written. That form will cover subsequent corrections to those > > > > > > changes, but it will not cover other unrelated future changes to the > > > > > > same program. > > > > > > > > > > > > Please use your full legal name (in ASCII characters) as the subject > line of the message. > > > > > > > --------------------------------------------------------------------- > > > > > > REQUEST: SEND FORM FOR CHANGES ALREADY MADE > > > > > > > > > > > > [What is the name of the program or package you're contributing to?] > > > > > > > > > > > > > > > > > > [Did you copy any files or text written by someone else in these > changes? > > > > > > Even if that material is free software, we need to know about it.] > > > > > > > > > > > > > > > > > > [Do you have an employer who might have a basis to claim to own > > > > > > your changes? Do you attend a school which might make such a > claim?] > > > > > > > > > > > > > > > > > > [For the copyright registration, what country are you a citizen of?] > > > > > > > > > > > > > > > > > > [What year were you born?] > > > > > > > > > > > > > > > > > > [Please write your email address here.] > > > > > > > > > > > > > > > > > > [Please write your postal address here.] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [Which files have you changed so far, and which new files have you > written > > > > > > so far?] > > > > > > > > > > > > > > > > > > > > -- > > > > Andrew :) > > > > > > > > Free Java Software Engineer > > > > Red Hat, Inc. (http://www.redhat.com) > > > > > > > > Support Free Java! > > > > Contribute to GNU Classpath and the OpenJDK > > > > http://www.gnu.org/software/classpath > > > > http://openjdk.java.net > > > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > > > > Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 > > > > > > > -- > > Andrew :) > > > > Free Java Software Engineer > > Red Hat, Inc. (http://www.redhat.com) > > > > Support Free Java! > > Contribute to GNU Classpath and the OpenJDK > > http://www.gnu.org/software/classpath > > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > > Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
