Hello Pekka, Mon, 6 Dec 2010 11:36:06 +0200 Pekka Enberg <penb...@kernel.org>:
> Hi all, > > I added the following PrintStream constructor API tests to Malva: > > https://github.com/penberg/malva/commit/b5020c862656c491fc81b2f4f3cee39a6444709a > > Some of the tests fail with GNU Classpath but Ivan's patch from June > cures most of the issues: > > http://developer.classpath.org/pipermail/classpath-patches/2010-June/006410.html > > [ There's still constructor throwing IllegalArgumentException where > NPE happens with Oracle JDK. ] > > The patch looks good to me apart from the "line_separator" static > modifier removal so FWIW, line_sepator issue (as well as the constructor NPE on null out) has already been discussed (http://article.gmane.org/gmane.comp.java.classpath.patches/12976/) > > Reviewed-by: Pekka Enberg <penb...@kernel.org> > > Pekka Regards.
