On Mon, 2011-01-24 at 23:36 +0000, Dr Andrew John Hughes wrote: > Oh this is one of Ivan's? I didn't spot that. Which number is it? > (so I don't review it all over again ;-) ) > > A test case would be great. I can't really review this patch well without > knowing what it's supposed to be doing.
Here's a test case I came up with. Ivan, anything else I should test for? Pekka // Tags: JDK1.5 // Copyright (C) 2011 Pekka Enberg // This file is part of Mauve. // Mauve is free software; you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation; either version 2, or (at your option) // any later version. // Mauve is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // You should have received a copy of the GNU General Public License // along with Mauve; see the file COPYING. If not, write to // the Free Software Foundation, 59 Temple Place - Suite 330, // Boston, MA 02111-1307, USA. package gnu.testlet.java.util.regex.Pattern; import gnu.testlet.*; import java.util.regex.*; public class quote implements Testlet { private TestHarness harness; public void test (TestHarness harness) { harness.check(Pattern.quote("hello"), "\\Qhello\\E"); boolean pass = false; pass = false; try { Pattern.quote(null); } catch (NullPointerException e) { pass = true; } harness.check(pass); } }