On 14 March 2011 21:56, Pekka Enberg <penb...@kernel.org> wrote: > Hi Andrew! > > On Mon, Mar 14, 2011 at 11:46 PM, Dr Andrew John Hughes > <ahug...@redhat.com> wrote: >> Thanks for catching this bug. I was going to approve it but you seem to >> have already committed >> it -- why??? > > I thought that'd be OK since the fix was pretty simple and I was able > to work out why the regression was there. Would you prefer that I wait > for an explicit ACKs in the future? >
Please just make it clear what you're asking for. If it's a fix you're sure about, then just post to the patches list with the FYI: subject prefix and commit straight away. If not, prefix the subject with RFC: and wait for feedback. With this one, it was unclear whether you wanted feedback or not and the commit wasn't immediate, but delayed by two days. http://www.gnu.org/software/classpath/docs/cp-hacking.html#SEC11 might be helpful. > Pekka > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
