On 08:51 Fri 27 May , Pekka Enberg wrote: > Hi Andrew, > > On Fri, May 27, 2011 at 6:45 AM, Dr Andrew John Hughes > <ahug...@redhat.com> wrote: > >> if WITH_JAR > >> -CREATE_GLIBJ_ZIP=$(JAR) cf glibj.zip gnu java javax org sun META-INF > >> +CREATE_GLIBJ_ZIP=$(JAR) cf glibj.zip gnu java javax org sun META-INF && > >> $(JAR) i glibj.zip > >> else > >> CREATE_GLIBJ_ZIP=$(ZIP) -r -D glibj.zip gnu java javax org sun META-INF > > >> /dev/null > >> endif > > > > My only concern with the patch (as I think Mark also raised on IRC) is that > > it means > > the index is only generated if WITH_JAR is set and not if $(ZIP) is used. > > > > Should we just drop the $(ZIP) option and require jar to be available? I > > suspect > > the reason we haven't done this is a bootstrapping issue. Does anyone have > > any > > thoughts? > > I think requiring jar is reasonable in 2011 and we should drop zip support. > ;-) > > Pekka
Somehow I knew you were going to say that... ;-) I think now that ecj is required to build, it's not the sort of blocker it once was. Plus there is fastjar. I'm happy for the current patch to go in, then we can make jar a requirement in a separate patch. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
