So I found the problem we were hitting with make distcheck and
the cp-tools documentation.  It turns out that the macro gcctabopt
was only being defined for certain types of output.  A normal build
will run texi2pod, where gcctabopt is defined, but make distcheck
also runs 'make dvi' which in turn leads to building with texi2dvi,
where gcctabopt was not being defined.

When I first found the issue, I did try removing gcctabopt but of
course @table does still need an argument so just removing it didn't
fix the issue.  I found that @table @code did work, so then it was
just a matter of working out why @table @gcctabopt (which expands
to @table @code) didn't.

Fixed thusly in the attached patch.

2012-03-07  Andrew John Hughes  <ahug...@redhat.com>

        * doc/cp-tools.texinfo:
        Move macro definition outside of if block
        so gcctabopt is always defined.

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
Index: doc/cp-tools.texinfo
===================================================================
RCS file: /sources/classpath/classpath/doc/cp-tools.texinfo,v
retrieving revision 1.8
diff -u -u -r1.8 cp-tools.texinfo
--- doc/cp-tools.texinfo        5 Jun 2010 20:18:00 -0000       1.8
+++ doc/cp-tools.texinfo        7 Mar 2012 15:25:44 -0000
@@ -20,10 +20,6 @@
 @end quotation
 @end copying
 
-@ifinfo
-@ifnotplaintext
-@setchapternewpage on
-
 @c Common macros to support generating man pages:
 
 @macro gcctabopt{body}
@@ -35,6 +31,10 @@
 @end smallexample
 @end macro
 
+@ifinfo
+@ifnotplaintext
+@setchapternewpage on
+
 @dircategory GNU Libraries
 @direntry
 * Classpath Tools: (cp-tools).  GNU Classpath Tools Guide

Attachment: signature.asc
Description: Digital signature

Reply via email to