----- Original Message ----- > Hi Pekka, > > Sat, 13 Oct 2012 10:22:52 +0300 от Pekka Enberg <penb...@kernel.org>: > > > > > > > Hi Ivan, > > (I'm also CC'ing Andrew.) > > Have you filled the FSF copyright assignment paperwork? I was looking > at your tree: > Of course I signed it (in May 2010). > > My mistake was to develop these fixes for 4 year with out > contribution and then (in 2010) upgrade to the recent Classpath and > push all at once (a big amount of code as you could see in that > branch). The problem that at that time there remained only 1 (or 2) > patch reviewers at Classpath. Andrew reviewed and accepted a couple > of patches. The discussion stopped at processing fixes to StrictMath > (Andrew requested StrictMath test, I wrote it and nothing more). > Since pushing of these patches to github, I'm fine to have multiple > Classpath "master" branches at different servers. >
I reviewed a fair deal of them and, from what I remember, most needed a fair amount of additional work (testing, fixing ChangeLog entries) to be suitable. Given they were mainly just minor fixes, they haven't been a high priority, but if they're now compiled in a git tree, this should be easier to do than going through a vast pile of e-mails. > I noticed some activity recently (e.g., moving from cvs to git) but > again I see the narrow place - code reviewing. > > May be it's time to change the policy of patch acceptance from > "please find a person who reviews (among 1 or 2 guys) your code" to > "if signed FSF paper, and you have patches, post them to ML, commit > to some feature development branch and, if no objections within 2-3 > weeks, merge the branch to master, in case of further objections > revert the patches". > No, I don't think this is suitable. > > > > > > > > > https://github.com/ivmai/classpath/commits/ivmai4review-v2 > > and was wondering if it's OK to try to push forward some of your bug > fixes? yes, good luck, ask me if something is unclear. You could > start with StrictMath fix. > > Regards, > Ivan > > > > > > > > > Pekka > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
