>>>>> ">" == MSlattery  <[EMAIL PROTECTED]> writes:

>> There is a bug in StringBuffer.insert(int, String)
>>     if (offset < len)
>>       System.arraycopy(this.str, offset, this.str, 
>>                     offset+str.length(), len - offset);

I don't understand why there is a test here.
Can't we just unconditionally do the arraycopy?

I agree with your patch.

I'll probably merge this with the libgcj implementation.  The libgcj
implementation is better in a few minor ways (less bugs, more
efficient).  The Classpath version has some things that are missing
(javadoc, JDK 1.2 methods).

Tom

Reply via email to