>>>>> ">" == Subramoney, Sreenivas <[EMAIL PROTECTED]> writes:

>> Below are the bugs I have encountered and proposed fixes.

Hi.

>> The loop in ../java/util/Properties::getProperty() does not
>> correctly search the default of the defalut property list. "prop"
>> must be correctly initialized and updated, and also the method
>> "get()" should be called on the "prop" object.

>> Therefore I believe the correct code for Properties::getProperty()
>> should look like :

Please send unidiffs or context diffs.
You can make these with `cvs diff -u' or `cvs diff -c'.
Diffs in those forms make it much easier to read the changes...

>> The functions ResourceBundle::getBundle(),
>> ResourceBundle::getObject() and ResourceBundle.getString() throw
>> MissingResourceException and calls to these should be surrounded by
>> a "try...catch" block if the caller function itself does not throw
>> it. I have added them where they were absent.

BTW have you considered merging the Classpath implementation of these
classes with the libgcj implementation?  I'm pretty sure libgcj
doesn't have these problems.

Tom

Reply via email to