>>>>> "Jeroen" == Jeroen Frijters <[EMAIL PROTECTED]> writes:
Jeroen> - FileOutputStream should not request read access, so the modes should Jeroen> be "w" and "a" I have a slight preference to use ints for the flags, not Strings. Jeroen> - write(byte[] buf, long offset, long length) should not use longs for Jeroen> offset and length Jeroen> - nativeReadByte shouldn't return a long Agreed. In general the argument and return types should match what the higher-level API is capable of. So for instance the byte argument to nativeWriteByte should just be an `int', as that is what is used in the other layers. Then we don't need casts anywhere. I don't understand why there is a nativeValid method and checks for nativeFd==-1. Shouldn't these be the same? If not, when will they be different? I think I see `nativeValid' as testing `is this FileDescriptor valid?'. In close(), if nativeClose throws an exception, won't the FileDescriptor be left in an inconsistent state? Tom _______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath
