Dalibor Topic wrote:
Dalibor Topic wrote:

Hi all,

attached is my fix to make ant (I think) work again with Classpath, fixing the bug reported by Jim Pick here [1]

Citing myself [2]:
this is a typical java library bug, and I've both produced and fixed a couple of those myself ;) You get an infinite recursion through calling overridden methods. Class A in library implements public methods b and c, where b internally (and of course undocumentedly ;) calls c. Class B from some user of the library extends A and overrides c to call b. When the user calls the method b of class B it goes straight into an infinite loop.


The fix is to avoid calling overridable methods from overridable methods, and to delegate those calls to internal, non-overridable versions of the methods.

2003-11-21 Dalibor Topic <[EMAIL PROTECTED]>

        * libraries/javalib/java/util/Hashtable.java:
        (internalcontainsValue) new method.
        (contains, containsValue) delegate to internalContainsValue.

Reported by: Jim Pick <[EMAIL PROTECTED]>

cheers,
dalibor topic

[1] http://mail.gnu.org/archive/html/classpath/2003-09/msg00009.html
[2] http://mail.gnu.org/archive/html/classpath/2003-09/msg00016.html


And this time, I even attached the patch! ;)

Yeah, the ChangeLog doesn;t look Classpath-ish enough.


2003-11-21 Dalibor Topic <[EMAIL PROTECTED]>

         * libraries/javalib/java/util/Hashtable.java
         (internalcontainsValue): new method.
         (contains, containsValue) delegate to internalContainsValue.

Reported by: Jim Pick <[EMAIL PROTECTED]>

cheers,
dalibor topic



_______________________________________________
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath

Reply via email to