On Tue, Jan 27, 2004 at 02:20:57PM -0600, Archie Cobbs wrote: > Hi Michael, > > This is regarding the Classpath patch to fix the O_SYNC/O_FSYNC problem > with FreeBSD I reported a while ago. > > I am currently unable to build from CVS because of auto* confusion > and version mismatches that I don't have time to figure out right now.
Yeah we have some autoconf/automake problems because I updated our configure system. Using autoconf 2.59/automake 1.7.9/1.8.x should work. It does for me. Older versions are known to be broken. > However I've tried classpath 0.07 with the patch applied (ie, this one:) > > > http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/native/target/generic/target_generic_file.h.diff?r1=1.11&r2=1.12&diff_format=u > > and it still does not work. The problem seems to be that when > target_generic_file.h is included, <fcntl.h> has not yet been > included. So neither of O_SYNC or O_FSYNC is defined yet, and > the result is the same (O_SYNC is chosen which is incorrect). > > Not sure what the "right" fix is but the patch below does work. > > Thanks, > -Archie > > __________________________________________________________________________ > Archie Cobbs * Halloo Communications * http://www.halloo.com > > --- classpath-0.07/native/jni/java-io/FileDescriptor.c.orig Wed Jul 30 05:11:34 > 2003 > +++ classpath-0.07/native/jni/java-io/FileDescriptor.c Tue Jan 27 14:16:45 > 2004 > @@ -49,6 +49,7 @@ > #include <config.h> > > #include <stdlib.h> > +#include <fcntl.h> > > /* FIXME: Need to make configure set these for us */ The fix is correct but in the wrong file. I will commit the real fix now. Thanx for reporting. Michael _______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath
