Hi!
I'm currently porting parts of GNU classpath to OVM (http://www.ovmj.org). In
the process I hit a problem with the access modifier of
FileDescriptor.setNativeFd(long). In order to avoid having to set that field
using reflection, I would need that method to be default (currently private).
I believe that change is generally the right thing to do. First, a private
accessor method makes little sense anyway. Also, in a similar context the
native_fd field in gnu.java.net.PlainSocketImpl is also package-scoped
(default) (there is a tiny difference in that PlainSocketImpl does not use
accessor methods, but I don't think it matters either way).
The (trivial) patch to make this happen is attached.
-Christian
Index: java/io/FileDescriptor.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/FileDescriptor.java,v
retrieving revision 1.20
diff -c -r1.20 FileDescriptor.java
*** java/io/FileDescriptor.java 25 Jan 2004 13:30:04 -0000 1.20
--- java/io/FileDescriptor.java 20 Mar 2004 04:41:35 -0000
***************
*** 388,394 ****
return nativeFd;
}
! private void setNativeFd(long nativeFd)
{
this.nativeFd = nativeFd;
}
--- 388,394 ----
return nativeFd;
}
! final void setNativeFd(long nativeFd)
{
this.nativeFd = nativeFd;
}
_______________________________________________
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath
