Michael Koch wrote: > I started to do some GNU classpath/VM separation work. I decided to > split the native methods of java.io.File into its own VM class called > java.io.VMFile. The refactoring worked really smooth and so I provide > here the patch for discussion. I have one minor nitpick myself VMFile > is located in java/io/ currently. Before commiting I will move it to > vm/reference/java/io/. > > Please review and comment.
Thanks! Looks good. I would like to see three additional changes: 1) Move the caseSenstive flag to VMFile, 2) Move listRoots to VMFile, 3) Move isHidden to VMFile. The current implementations can be moved to VMFile as is. Regards, Jeroen _______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath
