>>>>> "Guilhem" == Guilhem Lavaux <[EMAIL PROTECTED]> writes:
Guilhem> * first, it is not compilable in C++ mode. I've fixed that by Guilhem> moving some ifdef block and adding a '}' to finish the Guilhem> 'extern "C"' block. Hmm, we should probably merge in the libgcj version again, there are some minor ordering differences and whatnot here, and not for any reason I can discern. But this looks fine, I would say go ahead and check it in, if I come up with a merge patch later I'll of course post it... Guilhem> * second, I think the definition for JNI_CreateJavaVM is slightly Guilhem> wrong. Instead of Guilhem> JNIEXPORT jint JNICALL JNI_CreateJavaVM (JavaVM **, JNIEnv **, void *); I agree this would be preferable, but I think the spec argues against it. http://java.sun.com/j2se/1.4.2/docs/guide/jni/jni-12.html#JNI_CreateJavaVM Tom _______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://lists.gnu.org/mailman/listinfo/classpath
